~sircmpwn/dispatch.sr.ht#21: 
Build doesn't seem to get triggered

I have created a dispatch hook and then created a buildfile. However, it doesn't seem to trigger any builds. The webhook was delivered correctly for 3 times.

Status
REPORTED
Submitter
~biosmarcel
Assigned to
No-one
Submitted
1 year, 7 months ago
Updated
5 months ago
Labels
No labels applied.

~sircmpwn 1 year, 7 months ago

On the list of delivered webhooks on GitHub, what is the response given by sr.ht?

~biosmarcel 1 year, 7 months ago

{"errors": [{"field": "tags", "reason": "Invalid tag name, tags must use lowercase alphanumeric characters, underscores, dashes, or dots"}]}

~sircmpwn 1 year, 7 months ago

Thanks, should be an easy patch.

~biosmarcel 1 year, 7 months ago

I am not quite sure what that means

~sircmpwn 1 year, 7 months ago

dispatch.sr.ht uses the name of your repo as tags in the submitted build.

~biosmarcel 1 year, 7 months ago

I see, thanks for the info

Timothee Cour 5 months ago

Exactly the situation described in this issue https://github.com/nim-lang/Nim/issues/13553 which was closed because it's an issue with dispatch.sr.ht

You can open a ticket on sr.ht (dispatch.sr.ht handles github integration). But from their docs this is expected, as builds gets triggered on a push to a branch.

When you have flaky tests, a common strategy is to close/re-open to re-trigger builds (eg CI). This is what's done in popular CI eg azure-pipelines, travis, circle-ci IIRC. But when I close/re-open my PR, all azure-pipelines restart but not the builds.sr.ht pipeline.

The workaround is not good: adding a dummy commit just to re-start.

Is there an option to configure the yml file so that it triggers rebuild on close/reopen? Here's the yml file: https://github.com/nim-lang/Nim/blob/devel/.builds/freebsd.yml

Thanks!

~sircmpwn 5 months ago

You can also just click resubmit on the failed build. Or fix your flaky tests :)

Timothee Cour 5 months ago

You can also just click resubmit on the failed build. Or fix your flaky tests :)

For large complex projects fixing flaky tests isn't always easy. Where do I click re-submit here?

https://builds.sr.ht/~araq/job/160965

I'm not seeing any such UI Note that I'm not the owner, araq is; is he the only person that can re-submit? If so, we really need a way to be able to either re-submit as a non-owner (at very least for PR author although not sure how that detection would work), or to simply have an option in the yml file to trigger rebuild on PR close/re-open, like the other popular CI frameworks do (azure-pipelines, travis etc)

Thanks!

~sircmpwn 5 months ago

If you have a sourcehut account, you'll get a button to resubmit it under your account.

~timotheecour 5 months ago

Thanks, I confirm that it does work after creating an account; that being said, does the feature request sound reasonable, to remove some friction for users that merely want to contribute to a project that happens to use this service but don't have an account?

Furthermore, IMO you could make this restart feature more discoverable by adding a link for non logged-in users saying: "create an account to enable job re-submission"; had I seen such a link I might not have opened https://github.com/nim-lang/Nim/issues/13553 in the 1st place (regardless, option to restart build on PR re-open is still relevant IMO).

Thanks again!

~sircmpwn 5 months ago

I don't know. I've never found it a priority to fix someone else's bugs. Your test suite needs work.

~timotheecour 5 months ago

I've never found it a priority to fix someone else's bugs

likewise; I'm sending a PR on a project, and the CI breaks for reasons un-related to the PR (flaky tests), so now I have to fix someone else's bugs (those flaky tests) that are unrelated to my PR. Having test suites with 0 flaky tests is a desirable goal but not always practical for large complex projects.

Register here or Log in to comment, or comment via email.