Handle .git postfix on source URLs when doing source replacement

See downstream issue for details: https://github.com/ziglang/zig/issues/1960

Assigned to
1 year, 11 months ago
1 year, 11 months ago
No labels applied.

~sircmpwn 1 year, 11 months ago

Try updating your .build.yml to check out zig without the .git at the end of the URL.

~andrewrk 1 year, 11 months ago

Thanks - that fixed it. I'll leave this issue open with the feature request that if this mistake is made, the CI fails with an error message telling how to fix the yml

~sircmpwn 1 year, 11 months ago

Where should that error message go?

~sircmpwn REPORTED BY_DESIGN 1 year, 11 months ago

Also, it's not always in error. Sometimes people submit build manifests that don't actually need to clone the repo they're a member of.

~andrewrk 1 year, 11 months ago

The issue is that this is a poor user experience:

  • fill in a valid looking git URL into the sources field
  • enable the "pull request" dispatch
  • things appear to be working, but find out several weeks later that the "pull request -> build" dispatch hook is actually building master branch and not pull requests

Must I have a solution in mind for this to be an open todo item?

~sircmpwn 1 year, 11 months ago

I suppose that the GItHub-specific integration can deal with the GitHub-specific .git postfixes

~sircmpwn BY_DESIGN REPORTED 1 year, 11 months ago

Register here or Log in to comment, or comment via email.