~sircmpwn/git.sr.ht#224: 
Annotations displayed incorrectly

Can be seen in: https://git.sr.ht/~ihabunek/toot/tree/d13fa8685b300f96621fa325774913ec0f413a7f/toot/utils.py

The first annotation toot.exceptions should be two annotations, not one.

Here is the uploaded annotation JSON, notice that toot (line 11, col 6, len 4) and exceptions (line 11, col 11, len 10) are separate, non-overlapping annotations.

{
    "aa3a176c313240aa88ad8f83d64af9af677e2d0e": [
        {
            "type": "link",
            "lineno": 11,
            "colno": 6,
            "len": 4,
            "to": "toot/__init__.py",
            "title": "toot"
        },
        {
            "type": "link",
            "lineno": 11,
            "colno": 11,
            "len": 10,
            "to": "toot/exceptions.py",
            "title": "toot.exceptions"
        },
        {
            "type": "link",
            "lineno": 11,
            "colno": 29,
            "len": 12,
            "to": "toot/exceptions.py#L13",
            "title": "toot.exceptions.ConsoleError"
        },
        {
            "type": "link",
            "lineno": 42,
            "colno": 14,
            "len": 8,
            "to": "toot/utils.py#L19",
            "title": "toot.utils.get_text"
        },
        {
            "type": "link",
            "lineno": 51,
            "colno": 18,
            "len": 10,
            "to": "toot/utils.py#L32",
            "title": "toot.utils.parse_html"
        },
        {
            "type": "link",
            "lineno": 74,
            "colno": 12,
            "len": 13,
            "to": "toot/utils.py#L65",
            "title": "toot.utils.domain_exists"
        },
        {
            "type": "link",
            "lineno": 75,
            "colno": 15,
            "len": 12,
            "to": "toot/exceptions.py#L13",
            "title": "toot.exceptions.ConsoleError"
        }
    ]
}
Status
RESOLVED FIXED
Submitter
~ihabunek
Assigned to
No-one
Submitted
11 months ago
Updated
3 months ago
Labels
No labels applied.

~sircmpwn 3 months ago

Annotations seem to have fallen off of this repo, can you still reproduce this?

~ihabunek 3 months ago

Strange, I rebuilt the annotations, and now half the files aren't annotated.

E.g. this one is annotated: https://git.sr.ht/~ihabunek/toot/tree/a4c3d03b85081ef575679f20d147bba487a8e7b0/toot/auth.py

but this one isn't: https://git.sr.ht/~ihabunek/toot/tree/a4c3d03b85081ef575679f20d147bba487a8e7b0/toot/commands.py

even though script log claims to have created some annotations for it:

INFO:annotatepy:toot/commands.py: 181 annotations, 3.77s

This bug, however seems to be fixed since toot.exceptions is two separate annotations.

~sircmpwn 3 months ago

Note that the annotation URL has changed, and there's a best-effort fallback in place. Your annotation secret might be outdated.

https://man.sr.ht/git.sr.ht/annotations.md

~ihabunek REPORTED FIXED 3 months ago

Thanks, I'll check it out.

Register here or Log in to comment, or comment via email.