~sircmpwn/todo.sr.ht#156: Handle user/ticket mentions in the ticket body

Status
RESOLVED IMPLEMENTED
Submitter
~sircmpwn
Assigned to
No-one
Submitted
4 months ago
Updated
a month ago
Labels
No labels applied.

~sircmpwn 4 months ago

cc ~ihabunek

~ihabunek 4 months ago

Slight problem here. Currently, when a ticket is mentioned in a comment, the Event which is created will have ticket set to the mentioned ticket, and comment set to the comment where it was mentioned.

However, if a ticket is mentioned in another ticket body, we need to store both the ticket being mentioned, as well as the ticket whose body contains the mention.

Should I add a Event.mentioned_ticket field and migrate the data for existing events or do you have a better idea?

~sircmpwn 4 months ago

15:47:41 ihabunek ddevault: do you have an opinion on https://todo.sr.ht/~sircmpwn/todo.sr.ht/156 ? benaiah 15:47:53 ddevault z3ntu: try jq bencevans 15:48:17 ddevault ihabunek: hm benharri 15:48:42 ihabunek i'm not seeing a better solution bentglasstube 15:48:48 ddevault that plan almost looks good bgiannan 15:49:04 ddevault but it ticketid shouldn't be set to the new ticket BillTheBloke[m] 15:49:06 ddevault it should be set to the mentioned ticket blfr 15:49:14 ddevault and a new field added, like ticketmentionid, referring to the source of the mention bradfier 15:49:19 ddevault then commentid would be null brenns10 15:49:27 ihabunek right, that works too captainepoch 15:49:28 ddevault if ticket_id != the ticket mentioned, then the mentioning won't show up in that ticket's events cc0 15:49:57 ihabunek good point clandmeter

~ihabunek 4 months ago

that plan almost looks good but it ticketid shouldn't be set to the new ticket it should be set to the mentioned ticket and a new field added, like ticketmentionid, referring to the source of the mention then commentid would be null if ticket_id != the ticket mentioned, then the mentioning won't show up in that ticket's events

~sircmpwn 4 months ago

gah, fucking Qt clipboard

~ihabunek 3 months ago

Further discussion on the mailing list: https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3C20190327150946.GA24438%40groucho.local%3E

~ihabunek 3 months ago

This has been implemented.

~sircmpwn REPORTED IMPLEMENTED a month ago