~sircmpwn/tokidoki#1: 
Implement configurable auth providers

Status
RESOLVED IMPLEMENTED
Submitter
~sircmpwn
Assigned to
Submitted
9 months ago
Updated
8 months ago
Labels
No labels applied.

~bitfehler 9 months ago

Just for clarification: the ticket title says plural "providers", currently there is one. Is the goal to make that one configurable, to add others, or to make the configuration part of the generic interface?

~sircmpwn 9 months ago

Should have been more specific. The idea behind this ticket is to address this TODO:

https://git.sr.ht/~sircmpwn/tokidoki/tree/master/item/cmd/tokidoki/main.go#L32

By accepting a flag (-auth perhaps) which includes a connection string for the auth provider, e.g. imap://... or postgres://.... Then the scope of this ticket is parsing that URL, selecting IMAP from the list if imap:// or imaps:// is used, then rigging up the appropriate middleware.

~bitfehler 9 months ago

I pushed this to master, but it doesn't seem to pick up the "Implements:"? I figured this is mostly uncontroversial, but feel free to suggest style fixes or any specifics you had in mind, so I can get a better sense for your expectations/approaches/style/etc.:

https://git.sr.ht/~sircmpwn/tokidoki/commit/071ee7c729a3bb7d95c4e181a329ce1bd3dca319

~sircmpwn REPORTED IMPLEMENTED 9 months ago

LGTM. I would solve that TODO sooner rather than later, though.

~bitfehler 9 months ago

Conrad Hoffmann referenced this ticket in commit 071ee7c.

~migadu 8 months ago*

Just a bit of info on our preferred auth - we would like to use local CDB (constant db) lookups instead of sql or imap (as per my mail ~sircmpwn) For example using:

https://github.com/colinmarc/cdb

This is our preferred way for auth lookups at migadu and here it is preferred as it allows separation of DAV accounts from imap. We can expand on that later.

Register here or Log in to comment, or comment via email.