~soywod/pimalaya#206: 
Update Vim plugin hash in nixpkgs

Hello!

I'm a Neovim user and interested in using himalaya CLI and Vim interface. I installed them (using Nix), set up my IMAP and SMTP, confirmed that CLI works, and ran :Himalaya in Neovim. Then I got

Fetching INBOX emails…
error: unexpected argument '--account' found
Usage: himalaya <--config <PATH>|--output <FORMAT>|--color <MODE>|--debug|--trace>
For more information, try '--help'.
Error detected while processing function <lambda>5[1]..<SNR>59_on_exit[6]..function <lambda>5[1]..<SNR>59_on_exit:
line    6:
E605: Exception not caught: CLI error, see :messages for more information

I confirmed the same error happens on Neovim v0.9.5 and v0.10.10-dev-d3fa88b.

Not sure but it seems --account is escaped like so:

$ himalaya folder list -- --account m15a
error: unexpected argument '--account' found

-- NACAMURA Mitsuhiro

Status
REPORTED
Submitter
~m15a
Assigned to
No-one
Submitted
2 months ago
Updated
2 months ago
Labels
No labels applied.

~soywod 2 months ago

I'm a Neovim user and interested in using himalaya CLI and Vim interface. I installed them (using Nix), set up my IMAP and SMTP, confirmed that CLI works, and ran :Himalaya in Neovim. Then I got an error.

Which version did you install from Nix (which channel)? The API may not be aligned with the master branch of the plugin.

-- Regards Clément DOUIN https://soywod.me

~m15a 2 months ago

I tried the following Neovim versions:

  • v0.10.0-dev-d3fa88b from Neovim repository,
  • v0.9.5 from recent nixpkgs-unstable channel, and
  • v0.9.4 from recent nixos-23.11 channel.

All the cases have the same error.

Since the error might be due to my configuration, I've also tried to install the vanilla Neovim from nixpkgs-unstable and directly installed himalaya-vim to ~/.local/share/nvim/site/pack/local/start. Then I experienced https://todo.sr.ht/~soywod/pimalaya/204

I'll investigate this more later, thanks!

~m15a 2 months ago

Also note that I installed himalaya 1.0.0-beta.4.

~m15a 2 months ago

Aha okay I tried git revert 9a385c2 (commit message: adjust code for cli v1) on the plugin's master branch and then the above error was reproduced, meaning that Nixpkgs' plugin version is a bit old. Sorry for the disturbance!

~soywod 2 months ago

Nixpkgs' plugin version is a bit old

Something must be wrong in the nixpkgs definition of the Vim plugin.

https://github.com/NixOS/nixpkgs/blob/030938f1cdc0671cca7fabb18f2e9cc9a3045876/pkgs/applications/editors/vim/plugins/overrides.nix#L708-L716

Somehow the Vim plugin is not updated by their bot, I need to investigate. Last update was few days ago, yet I don't see any changes related to the Himalaya Vim plugin:

https://github.com/NixOS/nixpkgs/commit/14e81b55d90cc483a7b295294c41f1535797668b

-- Regards Clément DOUIN https://soywod.me

~m15a 2 months ago

On 15/05/2024 09:21, ~soywod wrote:

Something must be wrong in the nixpkgs definition of the Vim plugin.

The overridden hash seems out of date:

diff --git a/pkgs/applications/editors/vim/plugins/overrides.nix b/pkgs/applications/editors/vim/plugins/overrides.nix
index c3711bd412fe..9db34c5e0403 100644
--- a/pkgs/applications/editors/vim/plugins/overrides.nix
+++ b/pkgs/applications/editors/vim/plugins/overrides.nix
@@ -711,7 +711,7 @@
       owner = "~soywod";
       repo = "himalaya-vim";
       rev = "v${himalaya.version}";
-      sha256 = "W+91hnNeS6WkDiR9r1s7xPTK9JlCWiVkI/nXVYbepY0=";
+      sha256 = "lqXHIntg3MKqFQbY9eJHFP10hPIR71d78e0p2IfZaic=";
     };
   };

I think the above hash should be updated manually, since their bot updates only pkgs/applications/editors/vim/plugins/generated.nix and the bot tracks himalaya-vim's master branch.

-- NACAMURA Mitsuhiro

~soywod 2 months ago

The overridden hash seems out of date.

I think the hash should be updated manually, since their bot updates only pkgs/applications/editors/vim/plugins/generated.nix and the bot tracks himalaya-vim's master branch.

It makes sense, I will do it for the next release.

Thank you,

-- Regards Clément DOUIN https://soywod.me

~soywod 2 months ago

I changed the scope of this issue: it stands now for the Vim plugin update in Nixpkgs.

-- Regards Clément DOUIN https://soywod.me

Register here or Log in to comment, or comment via email.