~sthagen/liitos#79: Fix digital signature fields for south layout of approvals table

The new insertion of digital signature fields works well for east layout of the approvals table, but not for the south layout.

Only the first (Author) signature field is detected as such because the mapping of the role bearer names to the field name placeholder does fail and thus any subsequent field with an identical name (currently in v2024.11.24: THE.NAME.SLOT) is not recognized as a digital signautre field (tried in some version of acrobat reader).

Thanks.

Status: RESOLVED FIXED
Submitter: ~sthagen
Assigned to: ~sthagen
Submitted: 3 months ago
Updated: 3 months ago
Labels: Bug

~sthagen added Bug 3 months ago

~sthagen assigned ~sthagen 3 months ago

~sthagen 3 months ago

The fix is simple and in case someone likes to monkey patch until the fix release is out:

--- /install/place/liitos/approvals-of-2024.11.24.py        2024-11-25 06:29:00.029187100 +0100
+++ /install/place/liitos/approvals.py        2024-11-25 07:19:44.819187100 +0100
@@ -45,7 +45,7 @@ NO_DIG_SIG_FIELDS = bool(os.getenv('LIIT
 TOKEN_EXTRA_PUSHDOWN = r'\ExtraPushdown'  # nosec B105
 EXTRA_OFFSET_EM = 24
 TOKEN = r'\ \mbox{THE.ROLE.SLOT} & \mbox{THE.NAME.SLOT} & \mbox{} \\[0.5ex]'  # nosec B105
-DSF = r'\begin{Form}\hspace*{-2mm}\fbox{\digitalsignaturefield{71.10mm}{8.00mm}{THE.NAME.SLOT}}\end{Form}'
+DSF = r'\begin{Form}\hspace*{-2mm}\fbox{\digitalsignaturefield{71.10mm}{8.00mm}{name}}\end{Form}'
 if NO_DIG_SIG_FIELDS:
     DSF = r'\mbox{}'
 ROW_TEMPLATE = r'\ \mbox{role} & \mbox{name} & ' + DSF + r' \\[0.5ex]'

In short, the row template did not exposed the string name as replacement target also for the digital signature field and thus the placeholder kept its place.

~sthagen REPORTED FIXED 3 months ago

Fixed with version 2024.11.25.