~tsdh/swayr#14: 
window switcher is broken

same as #10, ext-window-of-same-layout current-workspace is broken again. to reproduce - open a firefox window in an empty workspace, and open 2 more instances using ctrl+n. on executing the above command, only 2 windows are being cycled

swayrd.log https://gist.github.com/Iss-in/4ae5b112be32d4a150a0518c054f9b56

Status
RESOLVED FIXED
Submitter
~isshin
Assigned to
No-one
Submitted
2 years ago
Updated
2 years ago
Labels
No labels applied.

~tsdh REPORTED FIXED 2 years ago

Tassilo Horn referenced this ticket in commit 93df424.

~tsdh 2 years ago

Tassilo Horn referenced this ticket in commit 93df424.

~tsdh 2 years ago

Tassilo Horn referenced this ticket in commit 93df424.

~tsdh 2 years ago

Tassilo Horn referenced this ticket in commit 93df424.

~tsdh 2 years ago

~isshin outgoing@sr.ht writes:

same as #10, ext-window-of-same-layout current-workspace is broken again. to reproduce - open a firefox window in an empty workspace, and open 2 more instances using ctrl+n. on executing the above command, only 2 windows are being cycled

Ah, reading your logs, I think I see the problem.

  1. You did a next/prev window command.
  2. You opened some new windows.
  3. You did another next/prev window command.

The problem was that at the beginnning of each next/prev window command, swayr records the windows focus timestamps (now ticks) into the timestamps (now ticks) used for next/prev commands (which should not be updated by events so that you get a stable ordering). But swayr cannot know reliably that one next/prev command sequence is over unless you issue some other swayr command in between. In your case, all new windows had a last focus timestamp for next/prev sequences of 0, so you always got the first of those 0-timestaps and never the other ones.

I've pushed a fix and released 0.12.2 and 0.13.0-beta.2 containing it. Basically, I now initialize the ticks for next/prev commands with the last focus tick so that new windows during a next/prev command sequence should be handled properly now.

Please give it a try.

Bye, Tassilo

~tsdh 2 years ago

Tassilo Horn referenced this ticket in commit 93df424.

Register here or Log in to comment, or comment via email.