~tsileo/microblog.pub#65: 
Wrong empty notes checks on index.html

Hello there,

I was just trying out microblog.pub, and the project looks awesome, but I think there are a few bugs in the index html when there are no notes.

First, the if objects check in https://git.sr.ht/~tsileo/microblog.pub/tree/afd253a1b4517d28ec4d172a458e2327cd622689/item/app/templates/index.html#L24 seems to pass even when there's nothing to show on the page. In my case, the empty-state div disappeared once I updated my profile, but I think this would also happen when the outbox has other objects that are not notes.

Second, the pagination code in https://git.sr.ht/~tsileo/microblog.pub/tree/afd253a1b4517d28ec4d172a458e2327cd622689/item/app/templates/index.html#L38-46 will insert an empty div if there are no pages. Maybe the check should be similar to the one in https://git.sr.ht/~tsileo/microblog.pub/tree/afd253a1b4517d28ec4d172a458e2327cd622689/item/app/templates/admin_outbox.html#L29-33 ?

Status
RESOLVED FIXED
Submitter
João Costa
Assigned to
No-one
Submitted
19 days ago
Updated
8 days ago
Labels
No labels applied.

~tsileo 17 days ago

Hey, I see, thanks for catching this!

I will take a look at this soon.

Thanks!

~tsileo REPORTED FIXED 8 days ago

I pushed a follow up commit to fix the empty div: https://git.sr.ht/~tsileo/microblog.pub/commit/a68b3e73184cf99d5999f4de47a71675f879224e and your patch was merged.

Thank you!

Register here or Log in to comment, or comment via email.