~ushin added hyperdrive.el 1 year, 5 months ago

~ushin 1 year, 4 months ago*

For org-mode links, I think this may require that the hyperdrive-org-link-follow be earlier in the org-link-parameters alist than any other handler for links without a specified type.

Also make sure that relatives links in other file types work, specifically:

• [X] orgmode
• [ ] markdown
• [X] HTML

~ushin REPORTED CLOSED 1 year, 4 months ago*

For markdown links, we may want to work with the markdown-mode maintainer, Jason Blevins, to make it easier to hook into markdown--browse-url.

~ushin CLOSED REPORTED 1 year, 4 months ago

~alphapapa 1 year, 4 months ago

Posted an issue inquiring about and volunteering to implement it on the markdown-mode repo: https://github.com/jrblevin/markdown-mode/issues/780

~alphapapa 1 year, 2 months ago

Pinged the maintainer again.

~ushin added 0.3.0 1 year, 2 months ago

~ushin REPORTED IMPLEMENTED 1 year, 1 month ago

Implemented in ae08015b. See #154 about supporting link targets in Markdown relative file links.

~alphapapa IMPLEMENTED REPORTED 1 year, 1 month ago

~alphapapa assigned ~alphapapa 1 year, 1 month ago

~alphapapa 1 year, 1 month ago

I can't find any way to upload an image to a comment here, so I put this on Imgur: https://i.imgur.com/gu1Jfi8.png That shows the files and directories I've used to test that the markdown-mode relative link code works (using current master of hyperdrive and my wip/extensible-follow-links branch of markdown-mode).

It all seems to work, so I'll submit the PR to markdown-mode now.

~ushin 1 year, 1 month ago

Thank you!!

~ushin REPORTED IMPLEMENTED 1 year, 1 month ago

Shohei Yoshida merged Adam's PR! https://github.com/jrblevin/markdown-mode/pull/808 Thank you!!!