~ushin/ushin#202: 
Fixes and cleanup for ushin-shapes

Please consider merging the fix-tag-format branch.

It consists mostly of cleanup. I did that last year, but because I could never get this package to work, neither before nor after this cleanup, I did not submit it until now.

Now I have looked into it more and found the bugs that prevented this from working before.

The value returned by ushin-shapes--build-tag does not have the expected form. I have pushed a commit to fix that to the mentioned branch.

Additionally there is a regression in svg-tag-mode. You can find the pull-request for that at https://github.com/rougier/svg-tag-mode/pull/61.

Status
REPORTED
Submitter
~tarsius
Assigned to
No-one
Submitted
9 months ago
Updated
7 months ago
Labels
No labels applied.

~tarsius 9 months ago

Link without the sentence-ending period being made part of the url https://github.com/rougier/svg-tag-mode/pull/61

~ushin 9 months ago

Thank you, Jonas! Please feel free to push the fix-tag-format branch to the https://git.sr.ht/~ushin/ushin-shapes.el remote.

Jonas Bernoulli 9 months ago ยท edit

Thank you, Jonas! Please feel free to push the fix-tag-format branch to the https://git.sr.ht/~ushin/ushin-shapes.el remote.

I though I had done that, but turns out I pushed it to the emacsmirror instead. Anyway, I've pushed it now.

~ushin 7 months ago

Yay! Your fixes work! Now I'll just ask Nicolas to please tag a new version of svg-tag-mode.el and then I can push the new version of ushin-shapes.el

Register here or Log in to comment, or comment via email.