#5 Use golang struct tags to control {de,}serialization order of fields 2 days ago

Comment by ~whereswaldon on ~whereswaldon/arbor-dev

This has been accepted and merged

REPORTED RESOLVED IMPLEMENTED

#8 Add timestamp field to arbor nodes 2 days ago

Comment by ~whereswaldon on ~whereswaldon/arbor-dev

This was resolved by https://lists.sr.ht/~whereswaldon/arbor-dev/patches/6528

REPORTED RESOLVED IMPLEMENTED

#10 Use cached keys for GPGSigner* tests 2 days ago

Comment by ~whereswaldon on ~whereswaldon/arbor-dev

This was resolved by https://lists.sr.ht/~whereswaldon/arbor-dev/patches/6673

REPORTED RESOLVED IMPLEMENTED

#10 Use cached keys for GPGSigner* tests 9 days ago

Comment by ~whereswaldon on ~whereswaldon/arbor-dev

I totally agree. You could actually put it in the existing tempdir and get all of the benefits of the current cleanup code for free.

#116 Patch export seems broken (perhaps it's just my repos?) 15 days ago

Comment by ~whereswaldon on ~sircmpwn/lists.sr.ht

Oh, I'm just an idiot. This is happening when there's a cover letter patch with no content. Most of the patches that I've applied haven't been done that way, so I was taken by surprise. Just a bad UX on git's part.

REPORTED RESOLVED FIXED

#116 Patch export seems broken (perhaps it's just my repos?) 15 days ago

Ticket created by ~whereswaldon on ~sircmpwn/lists.sr.ht

The last two times that I've tried to download a patch from the web UI, git has been unable to apply the patch.

For example this patch should apply to the master branch of this repo.

Yet when I try to use the suggested export command, I get:

curl -s https://lists.sr.ht/~whereswaldon/arbor-dev/%3C20190629222026.11049-1-christopher.waldon.dev%40gmail.com%3E/mbox | git am -3
Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

I can save the patch files from the mailing list in aerc and they work fine, so they seem to be corrupted (or something) as part of the download from lists.sr.ht's web endpoint. Any idea what's going on there?

#10 Use cached keys for GPGSigner* tests 17 days ago

forest-go added by ~whereswaldon on ~whereswaldon/arbor-dev

#10 Use cached keys for GPGSigner* tests 17 days ago

Ticket created by ~whereswaldon on ~whereswaldon/arbor-dev

There are (at time of writing) two forest-go tests that shell out to gpg2 on the host system to generate and use GPG keys. These tests are time-consuming both because the key generation process is expensive and because they often exhaust the system entropy pool (resulting in multi-minute hangs while the OS is trying to gather entropy).

We should be able to rewrite these tests so that they use the pre-generated keys from here instead of generating new ones. This would change the setup phase from generating a new key to importing an existing one.

Currently, due to the duration of those tests, we often skip them with the go test -short flag, but this is something of an antipattern. This would allow those tests to be about as fast as the others, so that we could run them more often.

#3 Cache pgp keys in tests 17 days ago

on ~whereswaldon/arbor-dev

REPORTED RESOLVED FIXED

#3 Cache pgp keys in tests 17 days ago

Comment by ~whereswaldon on ~whereswaldon/arbor-dev

~athorp96's changes have landed, so our basic tests now use hard-coded PGP keys.