Comment by ~xenrox on ~emersion/hut
There are only a few cases left where owner handling is not implemented yet. Most of them - if not all - are for resolvers that simply do not work for anyone besides the owner. One such case is hut lists acl list.
We could use a function like
aclByOwner
and try to retrieve them in case that ever gets supported (with regards to organizations) and let the API error out for now. Or we save that API call for now and simply golog.Fatal("acl list not supported for mailing lists that do not belong to the authenticated user")
.
Comment by ~xenrox on ~emersion/hut
Another upstream inconsistency is the event naming: LIST_UPDATED vs REPO_UPDATE
Find out which form is preferred and fix that.
Ticket created by ~xenrox on ~emersion/hut
This ticket is for tracking the status of webhook commands. Each type of webhook should have create, delete, list and show commands. Furthermore there should be a function to complete the webhook ID for delete and show. We should also take care that the mutations and queries are consistent upstream (e.g. naming of userWebhook).
#builds
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#git
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#hg
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: createWebhook instead of createUserWebhook (https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/39816)
#lists
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
- bug: https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20230317153254.mrpstkfuurcrlri6%40xenrox.net%3E
#mailing list webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok
#meta
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: createWebhook -> createUserWebhook, ProfileWebhookInput -> UserWebhookInput, deleteUserWebhook is still nullable, profileWebhook -> userWebhooks, profileWebhook -> userWebhook, remove "profile" from comments, api/webhooks deliverProfileWebhook -> deliverUserWebhook
#pages
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#paste
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#todo
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#tracker webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok
#ticket webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok
Comment by ~xenrox on ~emersion/hut
This was implemented in 5664e704.
REPORTED
RESOLVED IMPLEMENTEDComment by ~xenrox on ~emersion/hut
Doing that at the moment.
Comment by ~xenrox on ~emersion/hut
Thorben Günther referenced this ticket in commit 87831ea.
REPORTED
RESOLVED IMPLEMENTEDComment by ~xenrox on ~sircmpwn/lists.sr.ht
This was fixed in a3491203.
Comment by ~xenrox on ~emersion/gqlclient
This was implemented in ccaba8ec.
Ticket created by ~xenrox on ~sircmpwn/lists.sr.ht
The UpdatePatchset mutation currently fails if one wants to update a patch from a list where the user does have
moderate
access but isn't the list owner. This is caused by this query which hard-codes the list owner as the current user.Instead the access table should be consulted.
Comment by ~xenrox on ~emersion/hut
There was a small discussion in IRC on how this could look:
<emersion> it's a bit tricky to describe in CLI flags though… <emersion> maybe --files <glob> --cache-control <value> <ddevault> --cache 'foo/*.html:cache-control header goes here'? <emersion> or that <ddevault> alternatively, --cache=cache.rules where cache.rules is a file with slightly more structure
I would be in favor of the last option. A file should allow the biggest flexibility and leaves room for future settings without adding too many flags. The file could look similar to this - if we want to avoid pulling in new dependencies and use scfg:
notFound "404.html" fileConfigs { glob "*.png" { cacheControl "max-age=100" } glob "*.html" { cacheControl "max-age=1" } }
With that we could add a
site-config
flag to hut and deprecatenot-found
(or we leave notFound out from the file). Do you have further thoughts on this ~emersion?