~xenrox


#21 SIGSEGV in "builds list" with invalid access token 22 days ago

Comment by ~xenrox on ~emersion/hut

This bug is fixed with this commit. We actually don't need an additional nil check since the query only uses non-nullable fields.

REPORTED RESOLVED FIXED

#21 SIGSEGV in "builds list" with invalid access token a month ago

~xenrox assigned ~xenrox to #21 on ~emersion/hut

#21 SIGSEGV in "builds list" with invalid access token a month ago

bug added by ~xenrox on ~emersion/hut

#21 SIGSEGV in "builds list" with invalid access token a month ago

Comment by ~xenrox on ~emersion/hut

Thanks for your report!

This is caused by an out-of-date core-go dependency of builds.sr.ht. I have submitted a patch to fix this and will further add a nil check in hut.

#268 submitComment fails a month ago

Ticket created by ~xenrox on ~sircmpwn/todo.sr.ht

The submitComment mutations fails with:

pq: missing FROM-clause entry for table ""event""

Example query

mutation {
    submitComment(trackerId: 8263, ticketId: 1, input: { text: "test" }) {
        ticket {
            subject
        }
    }
}

#16 Align output fields a month ago

Comment by ~xenrox on ~emersion/hut

Indeed that looks good and seems to fix my problem.

#16 Align output fields a month ago

Comment by ~xenrox on ~emersion/hut

I wanted to align hut todo ticket list output and noticed one problem:

tabwriter does not handle coloured output very well. It counts the length of the formatting string as if it were displayed in the terminal. I worked around it by making all format strings the same length and while that worked for hut lists patchset list, we have a varying amount of coloured labels for each ticket. Right now I see 2-3 options how we could handle this:

  1. Iterate over all tickets, check which one has the most labels and pad the rest with with "invisible" formatting strings
  2. Put labels towards the end of the output
  3. Fork tabwriter and adjust the code as necessary (it is frozen)

#259 Zero timestamp causes GraphQL queries to fail 2 months ago

Comment by ~xenrox on ~sircmpwn/todo.sr.ht

With the current GraphQL implementation users can always generate such a ticket by setting the timestamp to the zero value (default in go). So there needs to be at least a validation that would forbid such tickets from being created ever again.

#265 defaultACL always returns false 2 months ago

Ticket created by ~xenrox on ~sircmpwn/todo.sr.ht

True permissions get returned as false by the GraphQL API. Example query:

query {
    me {
        trackers {
            results {
                name
                defaultACL {
                    browse
                }
            }
        }
    }
}

#259 Zero timestamp causes GraphQL queries to fail 2 months ago

Ticket created by ~xenrox on ~sircmpwn/todo.sr.ht

With such a timestamp it is no longer possible to query the "created" field on tickets. The API will return the error "must not be null". Example query:

query {
    trackerByOwner(owner: "~emersion", tracker: "hut") {
        tickets {
            results {
                id
                created
            }
        }
    }
}