Comment by ~xenrox on ~emersion/hut
Older hut versions do contain the necessary authentication for lists, it was added together with the exporter itself. What the latest release is missing is the authentication for builds, which was only recently added.
But yes, empty lists fail to export because the API returns the 404 status code.
Comment by ~xenrox on ~emersion/hut
The tabwriter got removed because it does not work correctly together with our pagination approach (pager). When fetching a new batch of results with a cursor, it could happen that some fields are longer now than in the first batch. Because of that a new formatting approach must be found for at least the following commands:
- ticket list
- patchset list
- * acl list
We could try a combination of:
- Placing long/variable length fields at the end (e.g. patchset subject)
- Declare a maximum length for fields and if it overflows cut off with an indicator. For some fields a maximum length is known beforehand (patchset status) and some are manageable, unless there is an edge case (date, ID: #1, #1000000).
Comment by ~xenrox on ~emersion/hut
owner
is processed everywhere now as well.
REPORTED
RESOLVED CLOSEDComment by ~xenrox on ~emersion/hut
I think in the future the error message will be more precise and go will download a newer toolchain automatically if your local one is too old.
Not sure what to think about this though.
REPORTED
RESOLVED CLOSEDComment by ~xenrox on ~emersion/hut
For
export
pagination is completely absent as well. Do we want to wait until - if even at all - some way to get all events with one query is available? Otherwise I could work on that as well.
Ticket created by ~xenrox on ~emersion/hut
This ticket is for tracking the status of pagination.
#builds: done
- list: done
- secrets: done
- user-webhook list: done
#git
- acl list: done
- artifact list: https://lists.sr.ht/~emersion/hut-dev/patches/42176
- list: done
- user-webhook list: done
#hg: done
- list: done
- user-webhook list: done
#lists: done
- acl list: done
- list: done
- patchset apply: done
- patchset list: done
- patchset show: done
- subscriptions: done
- user-webhook list: done
- webhook list: done
#meta: done
- audit-log: done
- ssh-key list: done
- pgp-key list: done
- user-webhook list: done
#pages: done
- list: done
- user-webhook list: done
#paste: done
- list: done
- user-webhook list: done
#todo: done
- acl list: done
- label list: done
- list: done
- ticket list: done
- ticket show: blocked https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3Cxahdsch64p7b2pflk3ad6tvgqo742fi2wuzuovilys3ye5okx5%40mowydyblziyu%3E
- ticket webhook list: done
- user-webhook list: done
- webhook list: done
#export: done
- builds: done
- git: done
- hg: done
- lists: done
- meta: done
- paste: done
- todo: done
Comment by ~xenrox on ~emersion/hut
By default you can find the minimum required version of go in the go.mod file.
Comment by ~xenrox on ~emersion/hut
There are only a few cases left where owner handling is not implemented yet. Most of them - if not all - are for resolvers that simply do not work for anyone besides the owner. One such case is hut lists acl list.
We could use a function like
aclByOwner
and try to retrieve them in case that ever gets supported (with regards to organizations) and let the API error out for now. Or we save that API call for now and simply golog.Fatal("acl list not supported for mailing lists that do not belong to the authenticated user")
.
Comment by ~xenrox on ~emersion/hut
Another upstream inconsistency is the event naming: LIST_UPDATED vs REPO_UPDATE
Find out which form is preferred and fix that.
Ticket created by ~xenrox on ~emersion/hut
This ticket is for tracking the status of webhook commands. Each type of webhook should have create, delete, list and show commands. Furthermore there should be a function to complete the webhook ID for delete and show. We should also take care that the mutations and queries are consistent upstream (e.g. naming of userWebhook).
#builds
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#git
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#hg
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: createWebhook instead of createUserWebhook (https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/39816)
#lists
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
- bug: https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20230317153254.mrpstkfuurcrlri6%40xenrox.net%3E
#mailing list webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok
#meta
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: createWebhook -> createUserWebhook, ProfileWebhookInput -> UserWebhookInput, deleteUserWebhook is still nullable, profileWebhook -> userWebhooks, profileWebhook -> userWebhook, remove "profile" from comments, api/webhooks deliverProfileWebhook -> deliverUserWebhook
#pages
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#paste
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#todo
#user webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: done
- naming: ok
#tracker webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok
#ticket webhooks
- create: done
- delete: done
- list: done
- show: missing
- completion: missing
- naming: ok